Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 1945 paper #2327

Merged
merged 2 commits into from
Jun 14, 2024
Merged

B 1945 paper #2327

merged 2 commits into from
Jun 14, 2024

Conversation

haydencleary
Copy link
Contributor

No description provided.

@haydencleary haydencleary self-assigned this Jun 13, 2024
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marketplace-frontend ❌ Failed (Inspect) Jun 13, 2024 8:17pm
marketplace-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 8:17pm

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (1875b74) to head (80287eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2327   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files          38       38           
  Lines        1825     1825           
  Branches      233      233           
=======================================
  Hits         1670     1670           
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,3 +1,3 @@
export const TypoLoading = () => {
export function TypoLoading() {
return <div />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should return a Skeleton here ?!

@haydencleary haydencleary merged commit fb3e538 into main Jun 14, 2024
9 of 11 checks passed
@haydencleary haydencleary deleted the b-1945-paper branch June 14, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants