WIP : new layout sections #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
84
to
88
| <Translate token={"common:form.reset"} /> | ||
| </Button> | ||
|
|
||
| <Button size={"md"} variant={"secondary"} onClick={onSave}> | ||
| <Translate token={"data:deepDive.filters.save"} /> | ||
| <Translate token={"common:form.save"} /> |
There was a problem hiding this comment.
Could use the translate prop
shared/constants/router.ts
Outdated
Comment on lines
29
to
31
| contributors: "/data/contributors", | ||
| projects: "/data/projects", | ||
| overview: "/data/overview", |
There was a problem hiding this comment.
Add root key? data.contributors.root for example
Comment on lines
58
to
62
| if (dataViewTarget === "contributor") { | ||
| router.push(`${NEXT_ROUTER.data.contributors}?${dateRangeType}${period}${series}${programAndEcosystemIds}`); | ||
| } else { | ||
| router.push(`${NEXT_ROUTER.data.projects}?${dateRangeType}${period}${series}${programAndEcosystemIds}`); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (dataViewTarget === "contributor") { | |
| router.push(`${NEXT_ROUTER.data.contributors}?${dateRangeType}${period}${series}${programAndEcosystemIds}`); | |
| } else { | |
| router.push(`${NEXT_ROUTER.data.projects}?${dateRangeType}${period}${series}${programAndEcosystemIds}`); | |
| } | |
| router.push(`${dataViewTarget === "contributor" ? NEXT_ROUTER.data.contributors : NEXT_ROUTER.data.projects}?${dateRangeType}${period}${series}${programAndEcosystemIds}`); |
?
app/data/layout.tsx
Outdated
| import { ProjectSidepanel } from "@/shared/panels/project-sidepanel/project-sidepanel"; | ||
| import { Translate } from "@/shared/translation/components/translate/translate"; | ||
|
|
||
| enum tabs { |
There was a problem hiding this comment.
I think enums should be capitalized, but then Tabs conflicts with the component of the same name. I went with Views for my enum ^^
…ct-table-contributor
haydencleary
approved these changes
Nov 25, 2024
alexbeno
deleted the
e-2492-flatten-navigation-to-only-have-project-table-contributor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.