Use getRawBytes to make the data reading faster

Signed-off-by: Tung D. Le <[email protected]>

src/Accelerators/NNPA/Transform/ZHigh/ZHighConstPropagation.cpp

@@ -53,8 +53,8 @@ static void getRawData(ElementsAttr attr_, std::vector<char> &data) {
          "Must be DenseElementsAttr or DisposableElementsAttr");
 
   if (disposalAttr) {
-    data.resize(numElements * getEltSizeInBytes(elemTy));
-    disposalAttr.readRawBytes(data);
+    ArrayBuffer<char> dstBytes = disposalAttr.getRawBytes();
+    data = dstBytes.get();
     return;
   }
 
@@ -94,6 +94,17 @@ ZHighStickifiedConstantOp emitZHighStickifiedConstant(PatternRewriter &rewriter,
 
   // Attribute type: tensor<sizeInBytes x i8>
   int64_t sizeInBytes = ztensor->buffer_size;
+
+  // DenseResourceElementsAttr valueAttr = DenseUI8ResourceElementsAttr::get(
+  //     RankedTensorType::get({sizeInBytes}, rewriter.getI8Type()),
+  //     stickifiedConstant.getOperation()
+  //         ->getDialect()
+  //         ->getNamespace(), // use the dialect as the blob "hint"
+  //     HeapAsmResourceBlob::allocateAndCopyWithAlign(
+  //         llvm::ArrayRef((char *)ztensor->buffer, sizeInBytes),
+  //         alignof(char)));
+  // allochelper_ztensor_free(ztensor);
+
   RankedTensorType dataType =
       RankedTensorType::get({sizeInBytes}, rewriter.getI8Type());
   std::unique_ptr<llvm::MemoryBuffer> memBuf = llvm::MemoryBuffer::getMemBuffer(

src/Dialect/ONNX/ElementsAttr/DisposableElementsAttr.hpp

@@ -259,10 +259,11 @@ class DisposableElementsAttr
   template <typename X>
   void readArray(MutableArrayRef<X> dst) const;
 
-  // Copies out the elements in a flat array in row-major order.
+  // Returns a pointer to the underlying data as a flat byte array, if
+  // everything aligns, otherwise makes and returns a copy.
   // If the element type is bool the data holds one byte (with value 0 or 1) per
   // bool (contrary to how DenseElementsAttr::getRawData() bit packs bools).
-  void readRawBytes(MutableArrayRef<char> dst) const;
+  onnx_mlir::ArrayBuffer<char> getRawBytes() const;
 
   // Returns a pointer to the underlying data as a flat WideNum array, if
   // everything aligns, otherwise makes and returns a copy.
@@ -313,11 +314,10 @@ class DisposableElementsAttr
   // Warning: This is inefficient because it calls unflattenIndex on flatIndex.
   size_t flatIndexToBufferPos(size_t flatIndex) const;
 
-  // Returns a pointer to the underlying data as a flat byte array, if
-  // everything aligns, otherwise makes and returns a copy.
+  // Copies out the elements in a flat array in row-major order.
   // If the element type is bool the data holds one byte (with value 0 or 1) per
   // bool (contrary to how DenseElementsAttr::getRawData() bit packs bools).
-  onnx_mlir::ArrayBuffer<char> getRawBytes() const;
+  void readRawBytes(MutableArrayRef<char> dst) const;
 
 }; // class DisposableElementsAttr