Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunONNXModel.py: save compilation info into a file when using --save-model or --cache-model #2994

Merged

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Oct 31, 2024

When using --save-model=save_folder or --cache-model=save_folder, a file compile.log is created inside save_folder that contains all the compilation log printed out by the compiler.

This is helpful to know how a model was compiled.

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I was actually thinking that we could just save the content of the command (actually the content of the -c argument), and that way we could even "reset" the cache if the options are different.

@AlexandreEichenberger AlexandreEichenberger merged commit d21f2db into onnx:main Oct 31, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15923 [push] Save compilation info in... started at 08:06

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14954 [push] Save compilation info in... started at 09:20

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15927 [push] Save compilation info in... started at 09:07

@tungld
Copy link
Collaborator Author

tungld commented Oct 31, 2024

I was actually thinking that we could just save the content of the command (actually the content of the -c argument), and that way we could even "reset" the cache if the options are different.

Coincidently, I have the same thought about compile flags :)

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14954 [push] Save compilation info in... failed after 1 hr 42 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15927 [push] Save compilation info in... passed after 2 hr 4 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15923 [push] Save compilation info in... passed after 2 hr 5 min

christopherlmunoz pushed a commit to christopherlmunoz/onnx-mlir that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants