Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong total number of phases for EmitObj and EmitJNI #2995

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Nov 1, 2024

Resolves #2990

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing it

@AlexandreEichenberger AlexandreEichenberger merged commit b39ed16 into onnx:main Nov 1, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15929 [push] Fix wrong total number o... started at 10:20

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14959 [push] Fix wrong total number o... started at 11:34

@AlexandreEichenberger
Copy link
Collaborator

@Sunny-Anand / @cjvolzka

Since this is such a simple PR and also very visible to users, maybe we should patch this one to the upcoming release?

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15933 [push] Fix wrong total number o... started at 11:21

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15929 [push] Fix wrong total number o... passed after 1 hr 24 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14959 [push] Fix wrong total number o... aborted after 1 hr 26 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15933 [push] Fix wrong total number o... aborted after 1 hr 26 min

christopherlmunoz pushed a commit to christopherlmunoz/onnx-mlir that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step count off when compiling for JNI
3 participants