Making runtime omunreachable static to support clang compiler #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Munoz <[email protected]>
Sunny-Anand
requested review from
tungld,
gongsu832,
AlexandreEichenberger and
Sunny-Anand
|
Jenkins Linux s390x Build #16024 [push] making runtime omunreach... started at 10:06 |
|
Jenkins Linux amd64 Build #16021 [push] making runtime omunreach... started at 09:06 |
|
Jenkins Linux ppc64le Build #15051 [push] making runtime omunreach... started at 10:21 |
|
Jenkins Linux s390x Build #16024 [push] making runtime omunreach... failed after 1 hr 1 min |
|
Jenkins Linux amd64 Build #16021 [push] making runtime omunreach... passed after 1 hr 18 min |
|
Jenkins Linux ppc64le Build #15051 [push] making runtime omunreach... passed after 2 hr 20 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling and linking runtime files on zOS using ibm-clang compiler will error.
Following suggestions "In C99 you need to provide an alternate (non-inline) definition of the function for when the compiler can't inline."
https://stackoverflow.com/questions/69384040/why-do-i-get-a-linking-error-with-clang-when-inlining-a-function-in-a-c-program
I am open to trying alternative methods to support clang compilers if there are other suggestions.