Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Natural Earth support in custom maps #1176

Closed
wants to merge 3 commits into from
Closed

Add Natural Earth support in custom maps #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0078c6d
Add Natural Earth support in custom maps
zstadler Feb 8, 2025
4cec7c5
Update planetiler.schema.json
zstadler Feb 8, 2025
390a916
Update ConfiguredMapMain.java
zstadler Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion planetiler-custommap/planetiler.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"osm",
"shapefile",
"geopackage",
"geojson"
"geojson",
"naturalearth"
]
},
"url": {
Expand Down
1 change: 1 addition & 0 deletions ...etiler-custommap/src/main/java/com/onthegomap/planetiler/custommap/ConfiguredMapMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
case SHAPEFILE -> planetiler.addShapefileSource(projection, source.id(), localPath, source.url());
case GEOPACKAGE -> planetiler.addGeoPackageSource(projection, source.id(), localPath, source.url());
case GEOJSON -> planetiler.addGeoJsonSource(source.id(), localPath, source.url());
case NATURALEARTH -> planetiler.addNaturalEarthSource(source.id(), localPath, source.url());

Check warning on line 78 in planetiler-custommap/src/main/java/com/onthegomap/planetiler/custommap/ConfiguredMapMain.java

View workflow job for this annotation

GitHub Actions / Analyze with Sonar

MAJOR CODE_SMELL 

Remove this call to a deprecated method, it has been marked for removal.

rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=1176&open=AZTnXHfqeaibCHOm78cU&id=onthegomap_planetiler
default -> throw new IllegalArgumentException("Unhandled source type for " + source.id() + ": " + sourceType);
}
}
Expand Down
4 changes: 3 additions & 1 deletion ...tommap/src/main/java/com/onthegomap/planetiler/custommap/configschema/DataSourceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ public enum DataSourceType {
@JsonProperty("geopackage")
GEOPACKAGE,
@JsonProperty("geojson")
GEOJSON
GEOJSON,
@JsonProperty("naturalearth")
NATURALEARTH
}
Loading