55 review models architecture #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at it can perform fit and predict and perform multivariate prediction even when the model is univariate.
…model class as well as model class instance. Update data module and dataset creation with torch. Update docs accordingly.
…his allows to ensure that evaluation pipeline is common to all models. Still, model must ensure to be able to process batch of data for inference (predict method).
…ata (a list of time series for now). It has been implemented for all models except scikit-learn compatible ones. Update documentation accordingly, and update dependencies.
…g holder. Refactor and clean some of the code.
…s and make some modification in model config class to pass dynamic parameters
…fixes in some modules. Benchmark is now running succesfully and we get the expected results.
7 tasks
fredmontet
reviewed
Jan 6, 2025
| @@ -1,6 +1,6 @@ | |||
| from .detection import detectors, abstract_detector | |||
| from .generation import generators, abstract_generator | |||
| from .modelling import Model, models, abstract_model | |||
| from .modelling import Model, model_interface, models | |||
There was a problem hiding this comment.
change to abstract_model
There was a problem hiding this comment.
updated in new commit
| # Darts Models | ||
| self.model = DartsForecastingModel(self.model, **self.params) | ||
| # This take all the sklearn regressors and pipelines | ||
| elif issubclass(self.model, BaseEstimator): | ||
| elif is_subclass_or_instance_of_subclass(self.model, BaseEstimator): | ||
| if size_of_ts > 1: |
There was a problem hiding this comment.
Make an issue to group the SkForecaster classes here so that the if isn't imbricated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, model architecture was improved. Specifically, this was done :