Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload speed limit for cloud recording #401

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/RecordingControl.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2009,6 +2009,14 @@ secfrac = "." 1*6DIGIT</programlisting>
</mediaobject>
</figure>
</section>
<section xml:id="_refCloudRecordingUpload">
<title>Uploading to an Object Storage</title>
<para>
A device signaling support for recording to an external target shall limit the upload speed so that a segment takes at least half as long as its duration to upload.
If the upload fails on the first try, the device shall retry uploading to the external target as fast as possible, to prevent loss of recording.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have ONVIF API to control the segment upload speed against segment size & duration? Or this PR is about only recording control doc update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, only update to the documentation. Some other use cases were raised during the F2F and the proposal will have to be reviewed and adapted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ jflevesque-genetec , thanks for clarifying it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jflevesque-genetec Is there any further update to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we still need to make some updates to it, but we haven't had the time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jflevesque-genetec thanks for the response I am sure it will be discussed and reviewed at the F2F.

For example, if a segment has a duration of 1 minute, then the device shall limit the upload speed so that it completes the upload after 30 seconds.
</para>
</section>
<section xml:id="_refCloudRecordingEncryption">
<title>Encryption</title>
<para>
Expand Down