Audio EQPreset Change #450

sujithhanwha · 2024-08-06T08:29:38Z

Audio EQ Preset related change

AudioOutputConfigurationOptions updated
SetEQPreset Method added
AudioOutputConfiguration updated with EqPreset token.

…s review comment

venki5685 · 2024-08-11T15:29:36Z

wsdl/ver10/schema/onvif.xsd

 					<xs:any namespace="##any" processContents="lax" minOccurs="0" maxOccurs="unbounded"/>   <!-- first Vendor then ONVIF -->
 				</xs:sequence>
 				<xs:anyAttribute processContents="lax"/>
 			</xs:extension>
 		</xs:complexContent>
 	</xs:complexType>
+
+	<xs:simpleType name="FrequencyRange">
+    <xs:restriction base="xs:string">


is this frequency range list standard for all type of EQPresets?

is this frequency range list standard for all type of EQPresets?

This is the common frequency range list, it can be different also. This enumeration is only for reference, the actual data type for this frequency range is xs:string, therefore we can extend it in future.

I like the xs:string for further extensibility.

robberos · 2024-09-06T11:19:54Z

wsdl/ver10/schema/onvif.xsd

+        </xs:element>
+        <xs:element name="Gain" type="xs:float">
+            <xs:annotation>
+                <xs:documentation>Normalized value (0.0 ~ 1.0).</xs:documentation>


Question on this scale, what do this normalized value mean? Is it linear, logarithmic? Only attenuation, not amplifiation?

Updated this to decibel based on Bangkok f2f discussion. Please re-check the updated commit.

robberos · 2024-09-06T11:25:29Z

wsdl/ver10/schema/onvif.xsd

+    	<xs:sequence>
+        <xs:element name="FrequencyRange" type="xs:string">
+            <xs:annotation>
+                <xs:documentation>Defined in tt:FrequencyRange, e.g., 20Hz-60Hz, 2kHz-4kHz.(Readonly)</xs:documentation>


Is it necessasary to pre-define list or more dynamically let device return capabilites with ranges and gain.

Device is free to choose its own, this is only a guideline.

If the FrequencyRange enum is only for guideline, I suggest dropping the pre-defined from the spec to avoid confusion. Instead, add more documentation on what to expect if necessary. Also, a common guideline for EQ is hard, right? As it exists many different implementations for different products and use cases. For example, another guideline would be a 10-band EQ based on the octave band (as described here https://en.wikipedia.org/wiki/Octave_band, also coming from an IEC standard).

I also suggest moving from specifying a frequency range to instead set the center frequency of the band. This would increase possibility to compare between products as the range may differ depending on kind of filter and bandwidth.

If the FrequencyRange enum is only for guideline, I suggest dropping the pre-defined from the spec to avoid confusion. Instead, add more documentation on what to expect if necessary. Also, a common guideline for EQ is hard, right? As it exists many different implementations for different products and use cases. For example, another guideline would be a 10-band EQ based on the octave band (as described here https://en.wikipedia.org/wiki/Octave_band, also coming from an IEC standard).

I also suggest moving from specifying a frequency range to instead set the center frequency of the band. This would increase possibility to compare between products as the range may differ depending on kind of filter and bandwidth.

@robberos , agree with your suggestion will discuss this change in upcoming telco and will update it.

@sujithhanwha @robberos I also found your suggestion interesting after reviewing your link.

robberos · 2024-09-06T11:28:06Z

wsdl/ver10/schema/onvif.xsd

+					<xs:documentation>Indicates whether the device allows changing the gain level for frequencies. (Readonly)</xs:documentation>
+				</xs:annotation>
+			</xs:element>
+			<xs:element name="FrequencyGainPair" type="tt:FrequencyGainPair" minOccurs="0" maxOccurs="unbounded">


for one EQPreset, is it required to return a specific frequency list or skip it to not show specific implemantation details?

Yes its implementation specific.

robberos · 2024-09-06T11:37:28Z

wsdl/ver10/schema/onvif.xsd

+	<!--===============================-->
+	<!--          EQPreset            -->
+	<!--===============================-->
+	<xs:complexType name="EQPreset">


EQPreset seems as a combined capabilities and configuration structure. Split into seperate?

Original proposal was something similar to have separate method, based on feedback from previous meetings, its defined like this.

Ok, thanks. resolved 👍

robberos · 2024-09-06T11:46:26Z

wsdl/ver10/schema/onvif.xsd

+			</xs:element>
+			<xs:element name="ScheduleToken" type="xs:string" minOccurs="0">
+				<xs:annotation>
+					<xs:documentation>Optional schedule token (if supported).</xs:documentation>


How is schedule to be used? Able to set many presets?

See also <xs:element name="Configuration" type="tt:EQPreset"> in SetEQPresetConfiguration, to be a list?

Now this parameter is removed in latest commit and clarified the issue raised during last F2F meeting in Bangkok.
Please check the latest commit0059eac

Agreed, EQPresets now unbounded. resolved

…y range

robberos · 2024-11-22T16:27:51Z

wsdl/ver20/media/wsdl/media.wsdl

@@ -2134,6 +2158,15 @@ image will be updated automatically and independent from calls to GetSnapshotUri
 				<soap:body parts="parameters" use="literal"/>
 			</wsdl:output>
 		</wsdl:operation>
+		<wsdl:operation name="SetEQPreset">


should we have a GetEQPreset? Even thoug it is a capability what is possible, if setting a EQ for the editable ones, I guess that won't show up in capabilities and instead need to be retrieved via a get-request?

should we have a GetEQPreset? Even thoug it is a capability what is possible, if setting a EQ for the editable ones, I guess that won't show up in capabilities and instead need to be retrieved via a get-request?

@robberos, Initially, we planned to include geteqpreset. However, during our previous discussions, some members preferred not to add more methods. Instead, we now provide the list of eqpreset in the GetAudioOutputConfigurationOptions response. If you believe this method is necessary, we can discuss it in the next telco.

oksana-tiushkina · 2024-12-01T14:45:59Z

wsdl/ver10/schema/onvif.xsd

@@ -1850,6 +1912,16 @@ IN NO EVENT WILL THE CORPORATION OR ITS MEMBERS OR THEIR AFFILIATES BE LIABLE FO
 					<xs:documentation>Minimum and maximum level range supported for this Output.</xs:documentation>
 				</xs:annotation>
 			</xs:element>
+			<xs:element name="EQPresetScheduleSupport" type="xs:boolean" minOccurs="0">


If it is true does it meant that Schedule Service shall be supported by a DUT?

Yes, when EQPresetScheduleSupport is true, the schedule service is supported by the DUT and is also available in the EQPreset feature.

oksana-tiushkina · 2024-12-01T14:50:49Z

wsdl/ver10/schema/onvif.xsd

+			</xs:element>
+			<xs:element name="isDefault" type="xs:boolean">
+				<xs:annotation>
+					<xs:documentation>This shows if the EQ preset is set as the default. When the scheduler isn't active, this preset will be in use. Only one preset can be marked as default among the eqpresets linked to an audio output.</xs:documentation>


Am I correctly understand that SetEQPreset with isDefault = true sets this preset default for all audio output listed in OutputTokensAvailable of the corresponding option?

Your understanding is correct, when its set to default, its applicable for all audio output tokens(OutputTokensAvailable) listed in corresponding option.

sujithhanwha added 2 commits August 6, 2024 17:27

Audio EQPreset Change

0651e9e

EQPreset FrequencyLevel pair changed to FrequencyGain based on Bosch'…

2ccce5a

…s review comment

venki5685 reviewed Aug 11, 2024

View reviewed changes

robberos reviewed Sep 6, 2024

View reviewed changes

Sujith Raman (Hanwha) and others added 2 commits September 22, 2024 08:50

Changes applied based on Bangkok F2F feedback

0059eac

Updated based on comments from Axis to remove the predefined frequenc…

1ea944b

…y range

robberos reviewed Nov 22, 2024

View reviewed changes

oksana-tiushkina reviewed Dec 1, 2024

View reviewed changes

sujithhanwha added the 25.06 label Jan 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Audio EQPreset Change #450

Audio EQPreset Change #450

sujithhanwha commented Aug 6, 2024

venki5685 Aug 11, 2024

sujithhanwha Aug 12, 2024

kieran242 Oct 24, 2024

robberos Sep 6, 2024

sujithhanwha Sep 22, 2024

robberos Sep 6, 2024

sujithhanwha Sep 22, 2024

robberos Oct 17, 2024

sujithhanwha Oct 22, 2024

kieran242 Oct 24, 2024

robberos Sep 6, 2024

sujithhanwha Sep 22, 2024

robberos Sep 6, 2024

sujithhanwha Sep 22, 2024

robberos Nov 22, 2024

robberos Sep 6, 2024

sujithhanwha Sep 22, 2024

robberos Nov 22, 2024

robberos Nov 22, 2024

sujithhanwha Nov 25, 2024

oksana-tiushkina Dec 1, 2024

sujithhanwha Dec 2, 2024

oksana-tiushkina Dec 1, 2024

sujithhanwha Dec 2, 2024

Audio EQPreset Change #450

Are you sure you want to change the base?

Audio EQPreset Change #450

Conversation

sujithhanwha commented Aug 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment