Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for license plate color. #513

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

HansBusch
Copy link
Member

Some countries use a background color code to uniquely identify a vehicle.

@sujithhanwha
Copy link
Contributor

Is it possible to re-use the 'Appearance/Color' field for this use, or should it be reserved exclusively for cases where the class type is 'vehicle,' and in such cases, the 'Appearance/Color' field represents the vehicle color?

@HansBusch
Copy link
Member Author

Depends on how we want vendors to model a car with plate. If those are separate objects then we can make use of the appearance color. I'm fine with that approach, but then we may want to document it.

@sujithhanwha
Copy link
Contributor

Depends on how we want vendors to model a car with plate. If those are separate objects then we can make use of the appearance color. I'm fine with that approach, but then we may want to document it.

Yes better to document this to avoid confusion. Please check if below suggestion for the description is fine ?
"Background color of the license plate. When the object class type is LicensePlate, it is recommended to use the object/appearance/color field. For instance, this color field can be used when license plate information is associated with a different object class type, such as Vehicle."

@HansBusch
Copy link
Member Author

Thanks for the suggestion. Tried it out and things get quite hard to understand.

Looks like the existing color descriptor only works for metadata separate object case. The event definition doesn't include the object information.

I would prefer to have a single approach either by adding the color object or by recommending usage of separate objects and using the existing color descriptor. Then still handling of event needs to be clarified.

@bsriramprasad
Copy link
Contributor

Reasonable to assume Car as parent object and License plate as child object to set some kind of relation between them and also lets us reuse the tt:Object.

Coming to event definition, I agree object information is missing , but we have recently updated the definition to include Parent ID and hence deriving color from metadata/object description should be possible?

  • <tt:ElementItemDescription Name="ObjectId" Type="tt:ObjectId"/>
  • <tt:ElementItemDescription Name="ParentObjectId" Type="tt:ObjectId"/>

Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HansBusch Approved after reviewing your submission which I though reasonable in its context. I then noted your last comment and @bsriramprasad comments.
I see more work to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants