Fix curator default persona editing #4158
Merged
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rkuo-danswer
approved these changes
Feb 28, 2025
| user.role == UserRole.CURATOR | ||
| or user.role == UserRole.GLOBAL_CURATOR | ||
| ): | ||
| is_default_persona = None |
There was a problem hiding this comment.
it feels like we should have a curator class with behavior like this stored inside instead of trying to reason out the behavior in a bunch of disparate functions.
| @@ -428,7 +436,7 @@ def upsert_persona( | |||
| remove_image: bool | None = None, | |||
| search_start_date: datetime | None = None, | |||
| builtin_persona: bool = False, | |||
| is_default_persona: bool = False, | |||
| is_default_persona: bool | None = None, | |||
There was a problem hiding this comment.
having persona in the parameter name seems redundant but i suppose this is propagating from other variable names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Curators should be able to edit featured assistants if they own them. They should NOT be able to modify the "featured" status
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.