-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to be compatible with Gatsby 3 #210
base: master
Are you sure you want to change the base?
Conversation
👷 Deploy request for gatsby-src-instagram accepted. 🔨 Explore the source changes: 791fefd 🔍 Inspect the deploy log: https://app.netlify.com/sites/gatsby-src-instagram/deploys/610d8323b5f0760007b5e0c2 |
Hey thanks for this!!!! |
@oorestisime Looks like Node.js v10 is configured in Netlify, but Gatsby 3.x requires at least v12. |
Added node version 12 but still fails (sorry cant check more than that for another week ) |
I will have another look as soon as I have time myself 😄 Thanks. |
Hey i just came back from holidays. Let me know if you want me to take a look as well :) |
The same for me 😄 Yes please have a look as well. That would help. Thanks in advance. |
Any luck with this upgrade? I am using Gatsby 3 and can't install your plugin via npm:
|
I'm getting new errors with Gatsby 4
|
This pull request is also working for me on Gatsby 4. After I used |
Any chance to get it merged and released? |
@@ -120,7 +120,7 @@ exports.sourceNodes = async ( | |||
{ actions, store, cache, createNodeId }, | |||
options | |||
) => { | |||
const { createNode, touchNode } = actions | |||
const { createNode, touchNode, getNode } = actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works. At least it didn't work for me on gatsby v4. I got getNode like this:
exports.sourceNodes = async (
{ actions, store, cache, createNodeId, getNode },
options
) => {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct. This change is required.
Maybe we can close this in favor of #239 |
From what I can see, there are no errors thrown after having upgraded the dependencies to be compatible with Gatsby 3. The only thing I had to change was commenting out the
hashtags
in/example/pages/index.js
. Revert that change in case your local example setup is different. Also, feel free to adjust this PR as it suits you. Hope this helps also others already running Gatsby 3.Fixed this warning that relates to this deprecation:
Fixes #188