Skip to content
This repository has been archived by the owner on Dec 25, 2024. It is now read-only.

Implement support for SLUB Dresden #553

Merged
merged 56 commits into from
Oct 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
7a9a9e8
Add SLUB API, implement parseSearchFields and getSupportFlags
StefRe Jan 5, 2019
3866167
Implement search, searchGetPage, getResultById, prolong, account, che…
StefRe Feb 2, 2019
f8ed93d
Implement getShareUrl
StefRe Feb 3, 2019
eade6e5
Add two more mediatypes
StefRe Feb 5, 2019
650c90d
Refactor for testing, add tests
StefRe Dec 30, 2019
6fc988e
Include year in search results only if not "null"
StefRe Jan 3, 2020
8215756
Correctly process reserved inter-library loan items
StefRe Jan 3, 2020
ce83f9a
Make test of expiry date work independently of locale
StefRe Jan 3, 2020
74fe9fc
implement cancel
StefRe Jan 13, 2020
118089a
Change search method from POST to GET
StefRe Jan 13, 2020
8c8500d
Add MIT license header
StefRe Jan 15, 2020
d18931b
Change all http requests methods from POST to GET
StefRe Jan 15, 2020
7688d74
Add remaining details to DetailedItem and fix reserved and lent items
StefRe Jan 16, 2020
7ed8139
Add SUPPORT_FLAG_ENDLESS_SCROLLING flag
StefRe Jan 19, 2020
71b77d2
Partly revert d18931b32d337cfeff279427e175c0c13bd0aea5
StefRe Jan 19, 2020
a29ba20
Process boolean status values in account request results
StefRe Jan 23, 2020
158c154
Implement reservation and tests for it
StefRe Jan 29, 2020
d8e86bf
Fix code analysis issues
StefRe Jan 29, 2020
9419288
Refactor mapping of json array to map for pickup points
StefRe Jan 31, 2020
ce9a706
Add SLUB API, implement parseSearchFields and getSupportFlags
StefRe Jan 5, 2019
36ab2ce
Implement search, searchGetPage, getResultById, prolong, account, che…
StefRe Feb 2, 2019
40f2247
Implement getShareUrl
StefRe Feb 3, 2019
ac04f22
Add two more mediatypes
StefRe Feb 5, 2019
b0de981
Refactor for testing, add tests
StefRe Dec 30, 2019
1711e27
Include year in search results only if not "null"
StefRe Jan 3, 2020
63b2688
Correctly process reserved inter-library loan items
StefRe Jan 3, 2020
3a5738c
Make test of expiry date work independently of locale
StefRe Jan 3, 2020
4ec3e24
implement cancel
StefRe Jan 13, 2020
5e3b189
Change search method from POST to GET
StefRe Jan 13, 2020
1d45d9e
Add MIT license header
StefRe Jan 15, 2020
954149c
Change all http requests methods from POST to GET
StefRe Jan 15, 2020
35d9b77
Add remaining details to DetailedItem and fix reserved and lent items
StefRe Jan 16, 2020
c52e665
Add SUPPORT_FLAG_ENDLESS_SCROLLING flag
StefRe Jan 19, 2020
3b8f663
Partly revert d18931b32d337cfeff279427e175c0c13bd0aea5
StefRe Jan 19, 2020
c5b2b7b
Process boolean status values in account request results
StefRe Jan 23, 2020
213fff6
Implement reservation and tests for it
StefRe Jan 29, 2020
d17be7e
Fix code analysis issues
StefRe Jan 29, 2020
0d52c8b
Fix error with no_criteria_input introduced in 118089a4
StefRe Feb 1, 2020
1519528
Refactor mapping of json array to map for pickup points
StefRe Jan 31, 2020
5c5fd77
Implement renewal for inter-library loan items and tests for it
StefRe Mar 21, 2020
47ecd6a
Fix various code formatting issues
StefRe Mar 21, 2020
c319ce0
Fix parseSearchFields according to new catalogue homepage
StefRe Mar 21, 2020
896f5f6
Fix status message
StefRe Sep 26, 2020
8f2cc2c
Remove colon from test resource file name
StefRe Sep 29, 2020
1bfc826
Replace ExpectedException.none() by assertThrows
StefRe Sep 29, 2020
89855c1
Merge branch 'feat/SLUB-API' of https://github.com/StefRe/opacclient …
StefRe Sep 30, 2020
87637d3
Make lent items status message strings translatable
StefRe Sep 30, 2020
b5ea66f
Fix code analysis warning overriding '@string/copy'
StefRe Sep 30, 2020
3b7ca5e
Rename string COPY to ITEM_COPY
StefRe Sep 30, 2020
db35f11
Fix typo and coding conventions issue
StefRe Oct 9, 2020
08dfa09
Add tests for Cancel
StefRe Oct 9, 2020
eedeeba
Use DummyStringProvider for testing
StefRe Oct 12, 2020
a18564d
Add comment about FL = inter-library loan
StefRe Oct 12, 2020
c81415a
Simplify code
StefRe Oct 12, 2020
6d6d602
Change JSON getters from opt to get
StefRe Oct 13, 2020
b518431
Set SearchResult.MediaType to NONE for unknown formats
StefRe Oct 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions opacclient/libopac/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ dependencies {
testImplementation 'org.hamcrest:hamcrest:2.2'
testImplementation 'org.hamcrest:hamcrest-library:2.2'
testImplementation 'org.mockito:mockito-core:1.10.19'
testImplementation 'com.shazam:shazamcrest:0.11'
}

task copyTestResources(type: Copy) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import de.geeksfactory.opacclient.apis.Primo;
import de.geeksfactory.opacclient.apis.SISIS;
import de.geeksfactory.opacclient.apis.SLIM;
import de.geeksfactory.opacclient.apis.SLUB;
import de.geeksfactory.opacclient.apis.SRU;
import de.geeksfactory.opacclient.apis.TestApi;
import de.geeksfactory.opacclient.apis.TouchPoint;
Expand Down Expand Up @@ -141,6 +142,8 @@ public static OpacApi create(Library lib, StringProvider sp, HttpClientFactory h
newApiInstance = new Koha();
} else if (lib.getApi().equals("netbiblio")) {
newApiInstance = new NetBiblio();
} else if (lib.getApi().equals("slub")) {
newApiInstance = new SLUB();
} else if (lib.getApi().equals("arena")) {
newApiInstance = new Arena();
} else if (lib.getApi().equals("slim")) {
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ public interface StringProvider {
String PLEASE_CHANGE_PASSWORD = "please_change_password";
String PROLONG_ALL_NOT_POSSIBLE = "prolong_all_not_possible";
String PROLONG_ALL_NO_ITEMS = "prolong_all_no_items";
String HOLD = "hold";
String REQUEST_READY = "request_ready";
String READINGROOM = "readingroom";
String REQUEST_PROGRESS = "request_progress";
String RESERVED_POS = "reserved_pos";
String ITEM_COPY = "item_copy";
String RESERVED = "reserved";
String RENEWED = "renewed";

/**
* Returns the translated string identified by identifier
Expand Down
3 changes: 3 additions & 0 deletions opacclient/libopac/src/main/resources/meanings/slub.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"Zugang": "DIGITAL"
}
Loading