add cl_abap_browser (#27)

open-abap · May 7, 2024 · bd57549 · bd57549
1 parent 3939365
commit bd57549
Show file tree

Hide file tree

Showing 15 changed files with 75 additions and 40 deletions.
diff --git a/abaplint.jsonc b/abaplint.jsonc
@@ -19,6 +19,13 @@
     "check_include": true,
     "uncaught_exception": true,
     "cds_legacy_view": true,
+    "expand_macros": true,
+    "fully_type_itabs": true,
+    "cds_comment_style": true,
+    "change_if_to_case": true,
+    "dynpro_checks": true,
+    "easy_to_find_messages": true,
+    "align_type_expressions": true,
     "no_external_form_calls": true,
     "superfluous_value": true,
     "cyclic_oo": false,

diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@abaplint/cli": "^2.106.8",
+    "@abaplint/cli": "^2.107.4",
     "@abaplint/runtime": "^2.8.24",
     "@abaplint/database-sqlite": "^2.8.0",
     "@abaplint/transpiler-cli": "^2.8.24"

diff --git a/src/alv/cl_alv_variant.clas.abap b/src/alv/cl_alv_variant.clas.abap
@@ -3,7 +3,7 @@ CLASS cl_alv_variant DEFINITION PUBLIC.
 
     METHODS delete_variants
       IMPORTING
-        it_variants   TYPE any
+        it_variants    TYPE any
       RETURNING
         VALUE(boolean) TYPE abap_bool.
 

diff --git a/src/cl_abap_browser.clas.abap b/src/cl_abap_browser.clas.abap
@@ -0,0 +1,28 @@
+CLASS cl_abap_browser DEFINITION PUBLIC.
+  PUBLIC SECTION.
+    CLASS-METHODS show_xml
+      IMPORTING
+        xml_string TYPE string
+        title      TYPE string OPTIONAL
+        container  TYPE REF TO cl_gui_container OPTIONAL
+        dialog     TYPE abap_bool OPTIONAL
+        printing   TYPE abap_bool OPTIONAL.
+
+    CLASS-METHODS show_html
+      IMPORTING
+        html_string TYPE string
+        title       TYPE string OPTIONAL
+        container   TYPE REF TO cl_gui_container OPTIONAL
+        dialog      TYPE abap_bool OPTIONAL
+        printing    TYPE abap_bool OPTIONAL.
+ENDCLASS.
+
+CLASS cl_abap_browser IMPLEMENTATION.
+  METHOD show_xml.
+    RETURN.
+  ENDMETHOD.
+
+  METHOD show_html.
+    RETURN.
+  ENDMETHOD.
+ENDCLASS.
diff --git a/src/cl_gui_cfw.clas.abap b/src/cl_gui_cfw.clas.abap
@@ -3,8 +3,8 @@ CLASS cl_gui_cfw DEFINITION PUBLIC.
     CLASS-METHODS
       compute_pixel_from_metric
         IMPORTING
-          x_or_y TYPE c
-          in     TYPE i
+          x_or_y     TYPE c
+          in         TYPE i
         RETURNING
           VALUE(val) TYPE i.
 
@@ -14,7 +14,7 @@ CLASS cl_gui_cfw DEFINITION PUBLIC.
     CLASS-METHODS
       set_new_ok_code
         IMPORTING new_code
-          TYPE clike.
+                           TYPE clike.
 ENDCLASS.
 
 CLASS cl_gui_cfw IMPLEMENTATION.

diff --git a/src/cl_gui_frontend_services.clas.abap b/src/cl_gui_frontend_services.clas.abap
@@ -24,7 +24,7 @@ CLASS cl_gui_frontend_services DEFINITION PUBLIC.
           write_field_separator TYPE char1 OPTIONAL
           confirm_overwrite     TYPE abap_bool OPTIONAL
         CHANGING
-          data_tab TYPE any.
+          data_tab              TYPE any.
 
     CLASS-METHODS file_exist
       IMPORTING
@@ -75,17 +75,17 @@ CLASS cl_gui_frontend_services DEFINITION PUBLIC.
     CLASS-METHODS
       file_save_dialog
         IMPORTING
-          window_title         TYPE string OPTIONAL
-          default_extension    TYPE string OPTIONAL
-          default_file_name    TYPE string OPTIONAL
-          file_filter          TYPE string OPTIONAL
-          initial_directory    TYPE string OPTIONAL
-          prompt_on_overwrite  TYPE abap_bool OPTIONAL
+          window_title        TYPE string OPTIONAL
+          default_extension   TYPE string OPTIONAL
+          default_file_name   TYPE string OPTIONAL
+          file_filter         TYPE string OPTIONAL
+          initial_directory   TYPE string OPTIONAL
+          prompt_on_overwrite TYPE abap_bool OPTIONAL
         CHANGING
-          filename             TYPE string
-          path                 TYPE string
-          fullpath             TYPE string
-          user_action          TYPE i OPTIONAL.
+          filename            TYPE string
+          path                TYPE string
+          fullpath            TYPE string
+          user_action         TYPE i OPTIONAL.
 
     CLASS-METHODS
       directory_browse
@@ -115,7 +115,7 @@ CLASS cl_gui_frontend_services DEFINITION PUBLIC.
     CLASS-METHODS
       directory_exist
         IMPORTING
-          directory TYPE string
+          directory     TYPE string
         RETURNING
           VALUE(result) TYPE abap_bool.
 
@@ -124,16 +124,16 @@ CLASS cl_gui_frontend_services DEFINITION PUBLIC.
         IMPORTING
           directory TYPE string
         CHANGING
-          rc TYPE i.
+          rc        TYPE i.
 
     CLASS-METHODS
       clipboard_export
         IMPORTING
           no_auth_check TYPE abap_bool OPTIONAL
         EXPORTING
-          data TYPE any
+          data          TYPE any
         CHANGING
-          rc TYPE i.
+          rc            TYPE i.
 
     CLASS-METHODS
       get_system_directory

diff --git a/src/cl_gui_picture.clas.abap b/src/cl_gui_picture.clas.abap
@@ -20,7 +20,7 @@ CLASS cl_gui_picture DEFINITION INHERITING FROM cl_gui_control PUBLIC.
 
     METHODS load_picture_from_url
       IMPORTING
-        url TYPE c
+        url    TYPE c
       EXPORTING
         result TYPE i.
 ENDCLASS.

diff --git a/src/cl_gui_splitter_container.clas.abap b/src/cl_gui_splitter_container.clas.abap
@@ -19,8 +19,8 @@ CLASS cl_gui_splitter_container DEFINITION PUBLIC.
 
     METHODS set_column_width
       IMPORTING
-        id    TYPE i
-        width TYPE i
+        id     TYPE i
+        width  TYPE i
       EXPORTING
         result TYPE i
       EXCEPTIONS
@@ -36,8 +36,8 @@ CLASS cl_gui_splitter_container DEFINITION PUBLIC.
 
     METHODS get_container
       IMPORTING
-        row TYPE i
-        column TYPE i
+        row              TYPE i
+        column           TYPE i
       RETURNING
         VALUE(container) TYPE REF TO cl_gui_container.
 ENDCLASS.

diff --git a/src/salv/cl_salv_aggregations.clas.abap b/src/salv/cl_salv_aggregations.clas.abap
@@ -2,8 +2,8 @@ CLASS cl_salv_aggregations DEFINITION PUBLIC.
   PUBLIC SECTION.
     METHODS add_aggregation
       IMPORTING
-        columnname   TYPE any
-        aggregation  TYPE i DEFAULT if_salv_c_aggregation=>total.
+        columnname  TYPE any
+        aggregation TYPE i DEFAULT if_salv_c_aggregation=>total.
 ENDCLASS.
 
 CLASS cl_salv_aggregations IMPLEMENTATION.

diff --git a/src/salv/cl_salv_columns_table.clas.abap b/src/salv/cl_salv_columns_table.clas.abap
@@ -7,7 +7,7 @@ CLASS cl_salv_columns_table DEFINITION PUBLIC.
     METHODS set_color_column
       IMPORTING value TYPE string.
     METHODS get_column
-      IMPORTING columnname TYPE string
+      IMPORTING columnname   TYPE string
       RETURNING VALUE(value) TYPE REF TO cl_salv_column.
     METHODS get
       RETURNING VALUE(value) TYPE string.

diff --git a/src/salv/cl_salv_functions_list.clas.abap b/src/salv/cl_salv_functions_list.clas.abap
@@ -2,7 +2,7 @@ CLASS cl_salv_functions_list DEFINITION PUBLIC.
   PUBLIC SECTION.
     METHODS set_all
       IMPORTING flag
-        TYPE abap_bool OPTIONAL.
+                     TYPE abap_bool OPTIONAL.
 
     METHODS get_functions
       RETURNING

diff --git a/src/salv/cl_salv_hyperlinks.clas.abap b/src/salv/cl_salv_hyperlinks.clas.abap
@@ -2,8 +2,8 @@ CLASS cl_salv_hyperlinks DEFINITION PUBLIC.
   PUBLIC SECTION.
     METHODS add_hyperlink
       IMPORTING
-        handle       TYPE any
-        hyperlink    TYPE any OPTIONAL
+        handle    TYPE any
+        hyperlink TYPE any OPTIONAL
       RAISING
         cx_salv_existing.
 

diff --git a/src/salv/cl_salv_layout_service.clas.abap b/src/salv/cl_salv_layout_service.clas.abap
@@ -2,16 +2,16 @@ CLASS cl_salv_layout_service DEFINITION PUBLIC.
   PUBLIC SECTION.
     CLASS-METHODS f4_layouts
       IMPORTING
-        s_key    TYPE any
-        layout   TYPE any OPTIONAL
-        restrict TYPE any OPTIONAL
+        s_key        TYPE any
+        layout       TYPE any OPTIONAL
+        restrict     TYPE any OPTIONAL
       RETURNING
         VALUE(value) TYPE salv_s_layout_info.
 
 
     CLASS-METHODS get_layouts
       IMPORTING
-        s_key TYPE any
+        s_key           TYPE any
       RETURNING
         VALUE(t_layout) TYPE salv_t_layout_info.
 ENDCLASS.

diff --git a/src/salv/cl_salv_table.clas.abap b/src/salv/cl_salv_table.clas.abap
@@ -10,7 +10,7 @@ CLASS cl_salv_table DEFINITION PUBLIC.
       EXPORTING
         r_salv_table TYPE any
       CHANGING
-        t_table TYPE any.
+        t_table      TYPE any.
     METHODS get_selections RETURNING VALUE(val) TYPE REF TO cl_salv_table.
     METHODS set_selected_rows IMPORTING val TYPE any.
     METHODS set_selection_mode IMPORTING val TYPE i.

diff --git a/src/tree/cl_gui_alv_tree.clas.abap b/src/tree/cl_gui_alv_tree.clas.abap
@@ -61,9 +61,9 @@ CLASS cl_gui_alv_tree DEFINITION INHERITING FROM cl_alv_tree_base PUBLIC.
         it_toolbar_excluding TYPE any OPTIONAL
         it_except_qinfo      TYPE any OPTIONAL
       CHANGING
-        it_outtab       TYPE STANDARD TABLE
-        it_filter       TYPE any OPTIONAL
-        it_fieldcatalog TYPE any OPTIONAL.
+        it_outtab            TYPE STANDARD TABLE
+        it_filter            TYPE any OPTIONAL
+        it_fieldcatalog      TYPE any OPTIONAL.
 
     METHODS delete_all_nodes
       EXCEPTIONS
@@ -122,7 +122,7 @@ CLASS cl_gui_alv_tree DEFINITION INHERITING FROM cl_alv_tree_base PUBLIC.
 
     METHODS get_children
       IMPORTING
-        i_node_key TYPE lvc_nkey
+        i_node_key  TYPE lvc_nkey
       EXPORTING
         et_children TYPE lvc_t_nkey.