Wait for cache sync for lister resources (#291)

Signed-off-by: zhujian <[email protected]>
open-cluster-management-io · Nov 29, 2024 · 57b1d28 · 57b1d28
1 parent a3a8096
commit 57b1d28
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/pkg/addonmanager/controllers/addonconfig/controller.go b/pkg/addonmanager/controllers/addonconfig/controller.go
@@ -71,6 +71,8 @@ func NewAddonConfigController(
 			return []string{key}
 		}, addonInformers.Informer()).
 		WithBareInformers(configInformers...).
+		// clusterManagementAddonLister is used, so wait for cache sync
+		WithBareInformers(clusterManagementAddonInformers.Informer()).
 		WithSync(c.sync).ToController(controllerName)
 }
 

diff --git a/pkg/addonmanager/controllers/agentdeploy/controller.go b/pkg/addonmanager/controllers/agentdeploy/controller.go
@@ -76,6 +76,8 @@ func NewAddonDeployController(
 		agentAddons:                agentAddons,
 	}
 
+	c.setClusterInformerHandler(clusterInformers)
+
 	f := factory.New().WithSyncContext(syncCtx).
 		WithFilteredEventsInformersQueueKeysFunc(
 			func(obj runtime.Object) []string {
@@ -126,23 +128,21 @@ func NewAddonDeployController(
 			},
 			workInformers.Informer(),
 		).
+		WithBareInformers(clusterInformers.Informer()).
 		WithSync(c.sync)
 
-	if c.watchManagedCluster(clusterInformers) {
-		f.WithBareInformers(clusterInformers.Informer())
-	}
 	return f.ToController(controllerName)
 }
 
-func (c addonDeployController) watchManagedCluster(clusterInformers clusterinformers.ManagedClusterInformer) bool {
+func (c addonDeployController) setClusterInformerHandler(clusterInformers clusterinformers.ManagedClusterInformer) {
 	var filters []func(old, new *clusterv1.ManagedCluster) bool
 	for _, addon := range c.agentAddons {
 		if addon.GetAgentAddonOptions().AgentDeployTriggerClusterFilter != nil {
 			filters = append(filters, addon.GetAgentAddonOptions().AgentDeployTriggerClusterFilter)
 		}
 	}
 	if len(filters) == 0 {
-		return false
+		return
 	}
 
 	_, err := clusterInformers.Informer().AddEventHandler(
@@ -169,8 +169,8 @@ func (c addonDeployController) watchManagedCluster(clusterInformers clusterinfor
 	if err != nil {
 		utilruntime.HandleError(err)
 	}
-	return true
 }
+
 func (c *addonDeployController) enqueueAddOnsByCluster() func(obj interface{}) {
 	return func(obj interface{}) {
 		accessor, _ := meta.Accessor(obj)

diff --git a/pkg/addonmanager/controllers/certificate/csrapprove.go b/pkg/addonmanager/controllers/certificate/csrapprove.go
@@ -109,6 +109,8 @@ func NewCSRApprovingController(
 				return true
 			},
 			csrInformer).
+		// clusterLister and addonLister are used, so wait for cache sync
+		WithBareInformers(clusterInformers.Informer(), addonInformers.Informer()).
 		WithSync(c.sync).
 		ToController("CSRApprovingController")
 }

diff --git a/pkg/addonmanager/controllers/certificate/csrsign.go b/pkg/addonmanager/controllers/certificate/csrsign.go
@@ -70,6 +70,8 @@ func NewCSRSignController(
 				return true
 			},
 			csrInformer.Informer()).
+		// clusterLister and addonLister are used, so wait for cache sync
+		WithBareInformers(clusterInformers.Informer(), addonInformers.Informer()).
 		WithSync(c.sync).
 		ToController("CSRSignController")
 }

diff --git a/pkg/addonmanager/controllers/registration/controller.go b/pkg/addonmanager/controllers/registration/controller.go
@@ -58,6 +58,8 @@ func NewAddonRegistrationController(
 			return true
 		},
 		addonInformers.Informer()).
+		// clusterLister is used, so wait for cache sync
+		WithBareInformers(clusterInformers.Informer()).
 		WithSync(c.sync).ToController("addon-registration-controller")
 }