remove duplicate controller and installstrategy

Signed-off-by: haoqing0110 <[email protected]>

cmd/example/helloworld/main.go

@@ -21,7 +21,6 @@ import (
 	"open-cluster-management.io/addon-framework/examples/helloworld_agent"
 	"open-cluster-management.io/addon-framework/pkg/addonfactory"
 	"open-cluster-management.io/addon-framework/pkg/addonmanager"
-	addonagent "open-cluster-management.io/addon-framework/pkg/agent"
 	cmdfactory "open-cluster-management.io/addon-framework/pkg/cmd/factory"
 	"open-cluster-management.io/addon-framework/pkg/utils"
 	"open-cluster-management.io/addon-framework/pkg/version"
@@ -109,7 +108,7 @@ func runController(ctx context.Context, kubeConfig *rest.Config) error {
 			),
 		).
 		WithAgentRegistrationOption(registrationOption).
-		WithInstallStrategy(addonagent.InstallAllStrategy(helloworld.InstallationNamespace)).
+		//		WithInstallStrategy(addonagent.InstallAllStrategy(helloworld.InstallationNamespace)).
 		WithAgentHealthProber(helloworld.AgentHealthProber()).
 		BuildTemplateAgentAddon()
 	if err != nil {

pkg/addonfactory/addonfactory.go

@@ -51,9 +51,9 @@ func NewAgentAddonFactory(addonName string, fs embed.FS, dir string) *AgentAddon
 		fs:  fs,
 		dir: dir,
 		agentAddonOptions: agent.AgentAddonOptions{
-			AddonName:           addonName,
-			Registration:        nil,
-			InstallStrategy:     nil,
+			AddonName:    addonName,
+			Registration: nil,
+			// InstallStrategy:     nil,
 			HealthProber:        nil,
 			SupportedConfigGVRs: []schema.GroupVersionResource{},
 		},
@@ -82,14 +82,14 @@ func (f *AgentAddonFactory) WithGetValuesFuncs(getValuesFuncs ...GetValuesFunc)
 // Deprecated: add annotation "addon.open-cluster-management.io/lifecycle: addon-manager" to ClusterManagementAddon
 // and define install strategy in ClusterManagementAddon spec.installStrategy instead.
 // The migration plan refer to https://github.com/open-cluster-management-io/ocm/issues/355.
-func (f *AgentAddonFactory) WithInstallStrategy(strategy *agent.InstallStrategy) *AgentAddonFactory {
+/*func (f *AgentAddonFactory) WithInstallStrategy(strategy *agent.InstallStrategy) *AgentAddonFactory {
 	if strategy.InstallNamespace == "" {
 		strategy.InstallNamespace = AddonDefaultInstallNamespace
 	}
 	f.agentAddonOptions.InstallStrategy = strategy
 
 	return f
-}
+}*/
 
 // WithAgentRegistrationOption defines how agent is registered to the hub cluster.
 func (f *AgentAddonFactory) WithAgentRegistrationOption(option *agent.RegistrationOption) *AgentAddonFactory {