Fix e2e

Signed-off-by: zhujian <[email protected]>
open-cluster-management-io · Apr 1, 2024 · f0d88fb · f0d88fb
1 parent bf6d47d
commit f0d88fb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/examples/deploy/addon/helloworld-helm/kustomization.yaml b/examples/deploy/addon/helloworld-helm/kustomization.yaml
@@ -1,6 +1,7 @@
 namespace: open-cluster-management
 
 resources:
+- resources/addon_deployment_config.yaml
 - resources/cluster_role.yaml
 - resources/cluster_role_binding.yaml
 - resources/service_account.yaml

diff --git a/examples/deploy/addon/helloworld-helm/resources/addon_deployment_config.yaml b/examples/deploy/addon/helloworld-helm/resources/addon_deployment_config.yaml
@@ -0,0 +1,6 @@
+apiVersion: addon.open-cluster-management.io/v1alpha1
+kind: AddOnDeploymentConfig
+metadata:
+  name: helloworldhelm-config
+spec:
+  agentInstallNamespace: open-cluster-management-agent-addon
diff --git a/examples/deploy/addon/helloworld-helm/resources/helloworld_helm_clustermanagementaddon.yaml b/examples/deploy/addon/helloworld-helm/resources/helloworld_helm_clustermanagementaddon.yaml
@@ -9,4 +9,7 @@ spec:
   supportedConfigs:
   - group: addon.open-cluster-management.io
     resource: addondeploymentconfigs
+    defaultConfig:
+      name: helloworldhelm-config
+      namespace: open-cluster-management
   - resource: configmaps
diff --git a/pkg/utils/addon_config.go b/pkg/utils/addon_config.go
@@ -47,7 +47,7 @@ func AgentInstallNamespaceFromDeploymentConfigFunc(
 			return "", fmt.Errorf("failed to get deployment config for addon %s: %v", addon.Name, err)
 		}
 		if config == nil {
-			return "", fmt.Errorf("failed to get deployment config for addon %s: %v", addon.Name, err)
+			return "", fmt.Errorf("failed to get deployment config for addon %s", addon.Name)
 		}
 
 		return config.Spec.AgentInstallNamespace, nil