Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue updating deployment manifests when uninstalling #226

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Dec 7, 2023

This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode.

Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem.

Relates:
https://issues.redhat.com/browse/ACM-8947

@mprahl
Copy link
Member Author

mprahl commented Dec 7, 2023

/cc @JustinKuli

@mprahl
Copy link
Member Author

mprahl commented Dec 7, 2023

/hold if you agree with the approach, I'll work to get the tests working

@zhiweiyin318
Copy link
Member

/LGTM
the manifestworks should not be re-created when cluster/addon is deleting, it is ok for me in this pre-delete case.
cc @qiujian16 @zhujian7

@openshift-ci openshift-ci bot added the lgtm label Dec 8, 2023
@mprahl mprahl force-pushed the continue-during-uninstall branch from e30130d to f9797c1 Compare December 8, 2023 15:05
@openshift-ci openshift-ci bot removed the lgtm label Dec 8, 2023
@mprahl
Copy link
Member Author

mprahl commented Dec 8, 2023

/unhold this is ready for review with the tests fixed

@mprahl
Copy link
Member Author

mprahl commented Dec 8, 2023

/cc @zhujian7

@openshift-ci openshift-ci bot requested a review from zhujian7 December 8, 2023 15:09
This allows an addon to update its deployment manifests while the
predelete hook is running. This is useful when telling the addon to
enter uninstall mode.

Additionally, if there is a bug in the uninstall and it keeps the
uninstall from succeeding, we need to allow container image updates to move
forward in the event the update fixes the problem.

Relates:
https://issues.redhat.com/browse/ACM-8947

Signed-off-by: mprahl <[email protected]>
@mprahl mprahl force-pushed the continue-during-uninstall branch from f9797c1 to 338a904 Compare December 12, 2023 20:39
@mprahl mprahl requested a review from zhujian7 December 12, 2023 20:39
@zhujian7
Copy link
Member

/lgtm

@mprahl
Copy link
Member Author

mprahl commented Dec 13, 2023

@zhiweiyin318 could you please take another look?

@zhiweiyin318
Copy link
Member

/LGTM
need approve from @qiujian16

@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Member Author

mprahl commented Dec 13, 2023

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 34f78ec into open-cluster-management-io:main Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants