🐛 Sort manifests for by Kind helm addons #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamalsaha
changed the title
tamalsaha
changed the title
tamalsaha
changed the title
qiujian16
reviewed
Mar 13, 2024
pkg/addonfactory/helm_agentaddon.go
Outdated
| @@ -260,3 +279,47 @@ func (a *HelmAgentAddon) releaseOptions( | |||
| Namespace: a.getValueAgentInstallNamespace(addon), | |||
| } | |||
| } | |||
|
|
|||
| // Manifest represents a manifest file, which has a name and some content. | |||
| type Manifest struct { | |||
There was a problem hiding this comment.
nit, should be private struct. I think you only use it internally?
Signed-off-by: Tamal Saha <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, tamalsaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d8d4494
into
open-cluster-management-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm will sort objects by kind when applying to a cluster. This pr also follows/copies the same code to sort rendered objects.