🌱 remove duplicate controller and installstrategy #252
Conversation
haoqing0110
force-pushed
the
br-migration
branch
4 times, most recently
from
0cd8cd4 to
4ea888a
Compare
Signed-off-by: haoqing0110 <[email protected]>
Signed-off-by: haoqing0110 <[email protected]>
haoqing0110
force-pushed
the
br-migration
branch
from
4ea888a to
6b13251
Compare
Signed-off-by: haoqing0110 <[email protected]>
haoqing0110
force-pushed
the
br-migration
branch
from
6b13251 to
4eca494
Compare
Signed-off-by: haoqing0110 <[email protected]>
|
/assign @qiujian16 |
haoqing0110
changed the title
| ) | ||
|
|
||
| // clusterManagementAddonController reconciles cma on the hub. | ||
| type clusterManagementAddonController struct { | ||
| // cmaManagedByController reconciles clustermanagementaddon on the hub |
There was a problem hiding this comment.
Is it necessary to remove this? will remove this controller later when addon manager no longer honor this annotation?
There was a problem hiding this comment.
Keep the controller is to remove the "self" added by framework 0.8.1/0.9.0.
will remove this controller later when addon manager no longer honor this annotation?
Yes. May need to keep this as long as we support 0.8.1/0.9.0, or users have to remove the "self" manually when they do a framework upgrade.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @zhujian7 |
|
/lgtm |
openshift-merge-bot
bot
merged commit b0ef02a
into
open-cluster-management-io:main
Summary
Ref open-cluster-management-io/ocm#355
Related issue(s)
Fixes #