-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix condition error of ManifestApplied. #273
🐛 Fix condition error of ManifestApplied. #273
Conversation
4753d73
to
3cfe4f8
Compare
/assign @qiujian16 |
could you add an integration test on this? |
9516078
to
c09e7e0
Compare
@qiujian16 It turns out there are there are u-t cases that are related to this, I've the condition check step here. |
could you also add some check in this https://github.com/open-cluster-management-io/addon-framework/blob/main/test/integration/kube/agent_hosting_deploy_test.go? |
Signed-off-by: xuezhaojun <[email protected]>
c09e7e0
to
e85a301
Compare
Sure, check steps added. |
@morvencao do you know when ce test failed? |
@qiujian16 e2e flake passed, please take another look. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.9 |
@qiujian16: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5c95275
into
open-cluster-management-io:main
@qiujian16: #273 failed to apply on top of branch "release-0.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: xuezhaojun <[email protected]>
Signed-off-by: xuezhaojun <[email protected]>
Summary
This PR is related to the #268
It turns out Manifests will always return objects, it's
BuildDeployWorks
to decide whether the objects is match to the current mode.And this time I tested with a self-build image on the test env.