Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 update helm example #286

Conversation

JoaoBraveCoding
Copy link
Contributor

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and qiujian16 November 8, 2024 18:34
@qiujian16
Copy link
Member

/approve

@JoaoBraveCoding thanks for the PR! You would need to signoff the commit with

git commit --amend -s
git push -f

Signed-off-by: Joao Marcal <[email protected]>
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/hold

@qiujian16
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 94bcb3c into open-cluster-management-io:main Nov 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants