Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the proposal of the new feature - MultipleHubs. #104

Conversation

xuezhaojun
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 October 17, 2023 04:00
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@xuezhaojun xuezhaojun changed the title Add the proposal of the new feature - swich hub WIP: Add the proposal of the new feature - swich hub Oct 19, 2023
@xuezhaojun xuezhaojun changed the title WIP: Add the proposal of the new feature - swich hub Add the proposal of the new feature - swich hub Oct 23, 2023
@xuezhaojun xuezhaojun force-pushed the enhance-klusterlet-switch-hub branch 19 times, most recently from 3fb1ea1 to 6cdda0c Compare October 31, 2023 01:07
@xuezhaojun xuezhaojun changed the title Add the proposal of the new feature - swich hub WIP:Add the proposal of the new feature - swich hub Nov 6, 2023
@qiujian16
Copy link
Member

@xuezhaojun I wonder if we should merge this, anything needs to be updated?

Signed-off-by: xuezhaojun <[email protected]>
@xuezhaojun xuezhaojun force-pushed the enhance-klusterlet-switch-hub branch from 6cdda0c to 58ed094 Compare December 11, 2024 07:42
@xuezhaojun xuezhaojun changed the title WIP:Add the proposal of the new feature - swich hub Add the proposal of the new feature - MultipleHubs. Dec 11, 2024
@xuezhaojun
Copy link
Member Author

@xuezhaojun I wonder if we should merge this, anything needs to be updated?

Thanks for reminding me, the PR is updated with the actual implementation, we can merge it now.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2024
Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 87ef953 into open-cluster-management-io:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants