Update the long-term policy compliance history design #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @JustinKuli |
JustinKuli
reviewed
Dec 20, 2023
| | kind | a string column of the policy Kind (e.g. ConfigurationPolicy) | | ||
| | api_group | a string column of the policy group (e.g. policy.open-cluster-management.io) | | ||
| | name | a string column for the name of the policy | | ||
| | namespace | an optional string column for the namespace of the policy. This will not be set for native OCM policies to avoid data duplication. | |
There was a problem hiding this comment.
Not set on OCM policies because it would just always be the cluster namespace?
mprahl
force-pushed
the
long-term-history3
branch
from
e85d3e5 to
5fbb14b
Compare
This stems from rethinking assumptions when doing the development. Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
long-term-history3
branch
from
5fbb14b to
52210e2
Compare
JustinKuli
approved these changes
Jan 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fa2f6dc
into
open-cluster-management-io:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stems from rethinking assumptions when doing the development.