Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional query parameters in the compliance events API #106

Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Jan 3, 2024

See each commit for the changes.

@openshift-ci openshift-ci bot requested review from deads2k and dhaiducek January 3, 2024 21:37
@openshift-ci openshift-ci bot added the approved label Jan 3, 2024
@mprahl
Copy link
Member Author

mprahl commented Jan 3, 2024

/cc @JustinKuli @gparvin

@openshift-ci openshift-ci bot requested review from gparvin and JustinKuli January 3, 2024 21:37
Comment on lines 249 to 252
- sort - the field to sort by. This defaults to `timestamps`.
- direction - the direction to sort by. This defaults to `desc`. It can be `asc` or `desc`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these field names and values match the GitHub REST API.

@mprahl mprahl requested a review from JustinKuli January 5, 2024 19:49
@mprahl mprahl force-pushed the long-term-history4 branch from 288dce7 to 482ebee Compare January 9, 2024 18:52
@mprahl mprahl force-pushed the long-term-history4 branch from 482ebee to b36c5ed Compare January 9, 2024 18:53
Copy link

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3e65b30 into open-cluster-management-io:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants