Minor updates to the long-term compliance history design #110
Conversation
This will no longer be used with a preference of using the policy ID directly. Signed-off-by: mprahl <[email protected]>
I think this history risks being inacurrate so it's best to not provide it at all for the time being. Signed-off-by: mprahl <[email protected]>
|
/cc @JustinKuli |
| #### Story 5 | ||
|
|
||
| As a policy user, I'd like to import my existing compliance history to the new compliance events database. |
There was a problem hiding this comment.
I liked this story. The commit message mentions that this history might be inaccurate, can you explain that? I still feel like it could be better than nothing...
There was a problem hiding this comment.
The things that would be missing is:
- We don't know the parent policy's info at the time of the event. We could assume the current parent's info, which is a safe assumption.
- We don't know the policy's spec at the time of the event, so we can't assume it hasn't changed.
- If the history goes back a long time, it implies to the user that it's accurate but it'd be missing things like deleted policies, deleted clusters, changes in policies, and etc.
I was thinking that we'd defer this until there is a specific ask and discuss if the user asking for it is okay with these caveats before we implement historical import.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d22e843
into
open-cluster-management-io:main
No description provided.