Add upgradeApproval field to OperatorPolicy #115
Conversation
| the cluster will be considered a match. If `spec.subscription.startingCSV` is set, that version can | ||
| be approved, even if it is not in this list. | ||
|
|
||
| The `spec.upgradeApproval` field specifies whether the an enforced "musthave" policy will approve |
There was a problem hiding this comment.
| The `spec.upgradeApproval` field specifies whether the an enforced "musthave" policy will approve | |
| The `spec.upgradeApproval` field specifies whether an enforced "musthave" policy will approve |
| any upgrade InstallPlans for the operator. *It has no effect when the policy is in "mustnothave"* | ||
| *mode*. This only affects InstallPlans for operators that are already installed on the cluster, | ||
| which upgrade or replace the operator; initial InstallPlans for an operator can be approved | ||
| regardless of this flag. If not set, the controller will behave as if it were set to `Automatic`. |
There was a problem hiding this comment.
I keep going back and forth on the default, but I think Automatic is a safe default option since upgrades should be safe within a channel.
There was a problem hiding this comment.
Did you mean Automatic is a good default in the OperatorPolicy, if this new field is not set? Or did you mean that Automatic in the Subscription is a good default? I updated this section some more, maybe it is more clear what I mean now.
It is hoped that this field makes some InstallPlan approval behaviors more obvious and helpful. Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
operatorpolicy-upgrades
branch
from
1443ccc to
20428c8
Compare
| always be Manual, regardless of the setting here. | ||
| each cluster's catalog. It is not allowed to set `spec.subscription.installPlanApproval`; the policy | ||
| will determine and set a value for that field based on the policy's `spec.versions` and | ||
| `spec.updgradeApproval` settings. |
There was a problem hiding this comment.
| `spec.updgradeApproval` settings. | |
| `spec.upgradeApproval` settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0335b24
into
open-cluster-management-io:main
It is hoped that this field makes some InstallPlan approval behaviors more obvious and helpful.