Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon template for supporting daemonset #120

Conversation

zhujian7
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 June 28, 2024 07:23
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also update the metadata.yaml on the lastModified time.

@zhujian7
Copy link
Member Author

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 June 28, 2024 08:02
@zhujian7 zhujian7 force-pushed the addontemplate-ds branch from 091420b to 703d6f4 Compare July 2, 2024 01:45
@zhujian7
Copy link
Member Author

zhujian7 commented Jul 2, 2024

@qiujian16 last-updated time in metadata.yaml updated.

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d85d6bd into open-cluster-management-io:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants