Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the expand hub template access design #126

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Jul 16, 2024

@openshift-ci openshift-ci bot requested review from deads2k and dhaiducek July 16, 2024 17:34
@mprahl
Copy link
Member Author

mprahl commented Jul 16, 2024

/cc @gparvin @JustinKuli @yiraeChristineKim
/hold

When permissions change after a watch has started, authorization is not reassessed until there is a new request, even
when the token expires. The [kubernetes-dependency-watches](https://github.com/stolostron/kubernetes-dependency-watches)
library leverages the client-go [RetryWatcher](https://pkg.go.dev/k8s.io/client-go/tools/watch#RetryWatcher) and it does
not currently error if the user does not have `watch` permissions. For when the watch is first started,
Copy link

@yiraeChristineKim yiraeChristineKim Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
not currently error if the user does not have `watch` permissions. For when the watch is first started,
not currently have an error if the user does not have `watch` permissions. For when the watch is first started,

@mprahl mprahl force-pushed the design-expanded-hub-templates-access2 branch from c3ee97d to fcc5fa0 Compare July 16, 2024 19:52
@yiraeChristineKim
Copy link

/hold

@mprahl
Copy link
Member Author

mprahl commented Jul 17, 2024

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 July 17, 2024 13:26
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mprahl mprahl force-pushed the design-expanded-hub-templates-access2 branch from fcc5fa0 to 4a5dd10 Compare July 17, 2024 14:36
@openshift-ci openshift-ci bot removed the lgtm label Jul 17, 2024
@mprahl
Copy link
Member Author

mprahl commented Jul 17, 2024

@yiraeChristineKim I fixed a typo. Could you please take another look?

@mprahl
Copy link
Member Author

mprahl commented Jul 17, 2024

/unhold

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1f9c7b7 into open-cluster-management-io:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants