Skip to content

Commit

Permalink
label selector is no longer supported in ManagedClusterSet
Browse files Browse the repository at this point in the history
Signed-off-by: Xiangjing Li <[email protected]>
  • Loading branch information
xiangjingli committed May 2, 2024
1 parent 7462dc4 commit 856f4ff
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 34 deletions.
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ GOHOSTARCH ?= $(shell go env GOHOSTARCH)
KB_TOOLS_ARCHIVE_NAME :=kubebuilder-tools-$(K8S_VERSION)-$(GOHOSTOS)-$(GOHOSTARCH).tar.gz
KB_TOOLS_ARCHIVE_PATH := $(TEST_TMP)/$(KB_TOOLS_ARCHIVE_NAME)

# specify the tag for ocm foundation images used in e2e test
OCM_IMAGE_TAG ?= v0.13.0

.PHONY: build

build:
Expand Down Expand Up @@ -113,7 +116,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)

.PHONY: deploy-ocm
deploy-ocm:
deploy/ocm/install.sh
IMAGE_TAG=$(OCM_IMAGE_TAG) deploy/ocm/install.sh

.PHONY: test-e2e
test-e2e: deploy-ocm
Expand Down
16 changes: 0 additions & 16 deletions examples/managedclusterset.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions examples/managedclustersetbinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
apiVersion: cluster.open-cluster-management.io/v1beta2
kind: ManagedClusterSetBinding
metadata:
name: all-openshift-clusters
name: global
namespace: openshift-gitops
spec:
clusterSet: all-openshift-clusters # Important: in newer releases use the 'global' or 'default' for clusterSet value instead.
clusterSet: global
2 changes: 1 addition & 1 deletion examples/openshift-gitops/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ with the `vendor: OpenShift` label into OpenShift GitOps (Argo CD).
## Configure
* Apply the following:
```shell
kubectl apply -f .
kubectl apply -f ./openshift-gitops
```
* Any OpenShift clusters with the correct label will be imported into the Argo CD provisioned by OpenShift GitOps.
* Check the Openshift GitOps (Argo CD) Configuration tab, to see the list of clusters
Expand Down
12 changes: 0 additions & 12 deletions examples/openshift-gitops/managedclusterset.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions examples/openshift-gitops/managedclustersetbinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
apiVersion: cluster.open-cluster-management.io/v1beta2
kind: ManagedClusterSetBinding
metadata:
name: all-openshift-clusters
name: global
namespace: openshift-gitops
spec:
clusterSet: all-openshift-clusters
clusterSet: global

0 comments on commit 856f4ff

Please sign in to comment.