Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitopsCluster support on non-OCP clussters #104

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-9736

@openshift-ci openshift-ci bot requested review from jnpacker and mikeshng September 11, 2024 23:18
Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (5730abf) to head (5422f02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   73.08%   72.68%   -0.41%     
==========================================
  Files          14       14              
  Lines        2779     2837      +58     
==========================================
+ Hits         2031     2062      +31     
- Misses        607      626      +19     
- Partials      141      149       +8     
Flag Coverage Δ
unit 72.68% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli xiangjingli merged commit 18358a1 into main Sep 12, 2024
7 of 8 checks passed
@xiangjingli xiangjingli deleted the gitopsClusterFeat branch September 12, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant