Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up log level to 1 to avoid massively logging #97

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

this pod is massively logging in one customer site. Since there is no applicationSet used there, customer doesn't care about the message.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f9e92) 72.91% compared to head (0544dee) 73.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   72.91%   73.02%   +0.10%     
==========================================
  Files          14       14              
  Lines        2769     2769              
==========================================
+ Hits         2019     2022       +3     
+ Misses        608      606       -2     
+ Partials      142      141       -1     
Flag Coverage Δ
unit 73.02% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Copy link

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli merged commit 62440e4 into main Feb 12, 2024
7 of 9 checks passed
@xiangjingli xiangjingli deleted the addLogLevel branch February 12, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants