-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update channel API description #86
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3a9a357
to
ca9d203
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 13 13
Lines 1638 1638
=======================================
Hits 1191 1191
Misses 353 353
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ca9d203
to
02e7da4
Compare
Signed-off-by: Xiangjing Li <[email protected]>
02e7da4
to
4a7ac83
Compare
@jc-berger Thanks Jake! I just fixed them all based on your comments and get them merged directly. Feel free to comment it if you find any new problems. I will open a new PR for addressing them if needed. |
https://issues.redhat.com/browse/ACM-8973