Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update channel API description #86

Merged
merged 1 commit into from
Jun 13, 2024
Merged

update channel API description #86

merged 1 commit into from
Jun 13, 2024

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-8973

@openshift-ci openshift-ci bot requested review from chenz4027 and rokej June 12, 2024 20:53
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli force-pushed the updateSpecDscription branch 2 times, most recently from 3a9a357 to ca9d203 Compare June 12, 2024 21:46
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.71%. Comparing base (987858a) to head (4a7ac83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          13       13           
  Lines        1638     1638           
=======================================
  Hits         1191     1191           
  Misses        353      353           
  Partials       94       94           
Flag Coverage Δ
unit 72.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli xiangjingli requested a review from jc-berger June 13, 2024 14:16
pkg/apis/apps/v1/channel_types.go Outdated Show resolved Hide resolved
pkg/apis/apps/v1/channel_types.go Show resolved Hide resolved
pkg/apis/apps/v1/channel_types.go Outdated Show resolved Hide resolved
pkg/apis/apps/v1/channel_types.go Outdated Show resolved Hide resolved
@xiangjingli xiangjingli force-pushed the updateSpecDscription branch from ca9d203 to 02e7da4 Compare June 13, 2024 19:46
@xiangjingli xiangjingli force-pushed the updateSpecDscription branch from 02e7da4 to 4a7ac83 Compare June 13, 2024 19:48
@xiangjingli xiangjingli merged commit cca056a into main Jun 13, 2024
7 of 8 checks passed
@xiangjingli xiangjingli deleted the updateSpecDscription branch June 13, 2024 19:53
@xiangjingli
Copy link
Collaborator Author

@jc-berger Thanks Jake! I just fixed them all based on your comments and get them merged directly. Feel free to comment it if you find any new problems. I will open a new PR for addressing them if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants