Skip to content

Commit

Permalink
igonre failed to get pullsecret error (#463)
Browse files Browse the repository at this point in the history
Signed-off-by: Zhiwei Yin <[email protected]>
  • Loading branch information
zhiweiyin318 authored May 15, 2024
1 parent fd65f37 commit 319d9af
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,9 @@ func (n *clusterManagerController) sync(ctx context.Context, controllerContext f
// check imagePulSecret here because there will be a warning event FailedToRetrieveImagePullSecret
// if imagePullSecret does not exist.
if config.ImagePullSecret, err = n.getImagePullSecret(ctx); err != nil {
return err
// may meet permission error in the upgrade case when the new rbac is not upgraded, so ignore err in this release.
// TODO: need return err if fail to get secret in the next release.
klog.Warningf("failed to get image pull secret: %v", err)
}

for _, reconciler := range reconcilers {
Expand Down

0 comments on commit 319d9af

Please sign in to comment.