✨ Adding aws-cli to docker image

[jaswalkiranavtar]

Summary

This image will be use as initContainer to copy the aws-cli to klusterlet-agent when initialized with awsirsa auth type.
This will allow us to keep registration-operator docker image clean.

Related issue(s)

Fixes # #514

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.32%. Comparing base (ed367fd) to head (6611460).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   63.51%   63.32%   -0.19%     
==========================================
  Files         185      186       +1     
  Lines       17838    17900      +62     
==========================================
+ Hits        11329    11335       +6     
- Misses       5576     5629      +53     
- Partials      933      936       +3     

Flag	Coverage Δ
unit	63.32% <ø> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qiujian16]

can we make this as arch agnostic? we would also need to support other arch.

[jaswalkiranavtar]

Pushed the change for quick feedback, please advise if it looks ok. Will fix the commit sign-off tomorrow moning.

[qiujian16]

looks good

[qiujian16]

also would you help to remind me on why we do not use aws go sdk? https://pkg.go.dev/github.com/aws/aws-sdk-go-v2. I remember we discussed this before. It will be good to leave some comments so we do not miss the reason.

[jaswalkiranavtar]

also would you help to remind me on why we do not use aws go sdk? https://pkg.go.dev/github.com/aws/aws-sdk-go-v2. I remember we discussed this before. It will be good to leave some comments so we do not miss the reason.

Yes, that is because the eks kubeconfig uses aws cli. We discussed about it and @deads2k suggested an option to copy aws cli from init container to klusterlet agent container. With this we do not have to maintain 2 copies of registration operator docker image, one for csr and other for aws auth.

open-cluster-management-io/enhancements#125 (comment)

[jaswalkiranavtar]

For ARM

ARG ARCH=aarch64

[qiujian16]

/approve

@mikeshng I think we also need to create a repo in quay for this image.

[mikeshng]

/approve

@mikeshng I think we also need to create a repo in quay for this image.

Ok. I have submitted the repo creation request. Thank you all for your patience.

[mikeshng]

/lgtm

repo has been created https://quay.io/repository/open-cluster-management/aws-cli

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaswalkiranavtar, mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment