Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fixes and clarifications to the Argo CD Agent integration solution #742

Conversation

mikeshng
Copy link
Member

@mikeshng mikeshng commented Dec 5, 2024

Summary

Fixes and clarifications to the Argo CD Agent integration solution: https://github.com/open-cluster-management-io/ocm/tree/main/solutions/argocd-agent

@openshift-ci openshift-ci bot requested review from jnpacker and qiujian16 December 5, 2024 15:17
@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@fxiang1
Copy link

fxiang1 commented Dec 5, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@fxiang1: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@fxiang1: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenz4027
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aa4f092 into open-cluster-management-io:main Dec 5, 2024
13 checks passed
@mikeshng mikeshng deleted the update-argocd-agent-solution branch December 5, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants