Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 set empty nodeselect to nil #799

Conversation

zhiweiyin318
Copy link
Member

Summary

the operator pod is pending because these fields are append to the deployment when nodeSelector is empty.

     nodeSelector:
        nodeSelectorTerms: ""

set nodeSelector to pointer, the fields will not be initialised if empty.

Related issue(s)

Fixes #

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.79%. Comparing base (970a1a2) to head (a98ee3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   63.78%   63.79%   +0.01%     
==========================================
  Files         192      192              
  Lines       18638    18638              
==========================================
+ Hits        11888    11891       +3     
+ Misses       5771     5769       -2     
+ Partials      979      978       -1     
Flag Coverage Δ
unit 63.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5df279f into open-cluster-management-io:main Jan 14, 2025
15 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-nodeselector branch January 14, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants