-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation outlining the steps to transition from placementRul… #491
Add documentation outlining the steps to transition from placementRul… #491
Conversation
dffce76
to
05725e2
Compare
/cc @dhaiducek @mprahl |
543daff
to
e9fe792
Compare
367fc2b
to
1ebbd75
Compare
1ebbd75
to
fa1e141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I have one comment about the sections.
Please also run the code through a linter to reflow any long lines to match the rest of the file.
fa1e141
to
0fb8ca1
Compare
0fb8ca1
to
2f79773
Compare
2f79773
to
6c81ab4
Compare
Ref: https://issues.redhat.com/browse/ACM-12698 Signed-off-by: yiraeChristineKim <[email protected]>
6c81ab4
to
8f7d4e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @yiraeChristineKim!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
baa1415
into
open-cluster-management-io:main
Add documentation outlining the steps to transition from placementRule to placement
Ref: https://issues.redhat.com/browse/ACM-12698