Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-dead-urls-docs #504

Conversation

enisozgen
Copy link
Contributor

This PR updates broken URLs (404s) in the README and other documentation files.

@dhaiducek
Copy link
Member

Nice! 🎉 Thanks for fixing these links, @enisozgen! It looks like the commit is missing the DCO signoff, though (the alternative to the CLA). Since there's only one commit here, you can add it using the --amend flag and a force-push:

git commit --amend --signoff --no-edit
git push --force

Git doc ref: https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s

Signed-off-by: Enis OEZGEN <[email protected]>
@enisozgen
Copy link
Contributor Author

Hello @dhaiducek,

I signed the commit as you wanted fyi
Signed-off-by: Enis OEZGEN <[email protected]>
Regards

Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, enisozgen, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ab8999c into open-cluster-management-io:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants