Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 avoid to print whole event in the error log #83

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Oct 8, 2024

Summary

If the event is too large, it will cut off the error message in the log

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 October 8, 2024 02:40
@skeeey
Copy link
Member Author

skeeey commented Oct 8, 2024

/assign @qiujian16

@qiujian16
Copy link
Member

if it is only event id, how is it valuable? Can we use it to find the specific event?

@skeeey
Copy link
Member Author

skeeey commented Oct 8, 2024

if it is only event id, how is it valuable? Can we use it to find the specific event?

Using event context instead of event id, the context will include the all event meta data, e.g. id, source, type, extensions etc.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2024
Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2fd7e26 into open-cluster-management-io:main Oct 8, 2024
10 checks passed
@skeeey skeeey deleted the log branch October 8, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants