Add cache manager extension #251
Open
+412
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocm-ci-robot-0
added
reviewed/ok-to-test
TuanAnh17N
reviewed
Nov 20, 2024
8R0WNI3
force-pushed
the
8R0WNI3-cache-manager
branch
from
9424c79
to
9f0582c
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
8 tasks
zkdev
requested changes
Nov 21, 2024
ccwienk
requested changes
Nov 21, 2024
charts/extensions/charts/cache-manager/templates/cache-manager.yaml
Outdated
Show resolved
Hide resolved
8R0WNI3
force-pushed
the
8R0WNI3-cache-manager
branch
from
9f0582c
to
385c911
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
8R0WNI3
force-pushed
the
8R0WNI3-cache-manager
branch
from
385c911
to
1628335
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
ccwienk
reviewed
Nov 22, 2024
| return | ||
|
|
||
| logger.info(f'Current cache size: {bytes_to_str(size)}') | ||
| logger.info(f'Max cache size: {bytes_to_str(cfg.max_cache_size_bytes)}') |
There was a problem hiding this comment.
maybe for future pullrequest: should we expose cache-metrics (e.g. for prometheus)?
There was a problem hiding this comment.
I think that could also be something we could add to the delivery-service, i.e. adding information on cache hits/misses to prometheus.
8R0WNI3
force-pushed
the
8R0WNI3-cache-manager
branch
from
1628335
to
ce06432
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
8R0WNI3
force-pushed
the
8R0WNI3-cache-manager
branch
from
ce06432
to
ebc541b
Compare
ocm-ci-robot-0
added
the
reviewed/ok-to-test
ocm-ci-robot-0
removed
the
reviewed/ok-to-test
The cache manager's purpose in this first iteration is to cleanup the persistent db cache according to the supplied configuration via the scan configuration CR. If the configured `max_cache_size_bytes` is exceeded, cache entries are removed according to the configured weights in the `cleanup_strategy` cache strategy property until the cache size reaches `max_buffer_bytes` again.
8R0WNI3
force-pushed
the
8R0WNI3-cache-manager
branch
from
ebc541b
to
d39c94d
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: