[wip] Custom Fields #5742
Open
[wip] Custom Fields #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toplenboren
added
🔬 WIP
pahaz
reviewed
Feb 3, 2025
| if (user.isAdmin || user.isSupport) return true | ||
|
|
||
| const isBulkRequest = Array.isArray(originalInput) | ||
| // Bulk requests are not supported in canManageObjectsAsB2BAppServiceUser |
pahaz
reviewed
Feb 3, 2025
| if (user.deletedAt) return false | ||
| if (user.isAdmin || user.isSupport) return true | ||
|
|
||
| const isBulkRequest = Array.isArray(originalInput) |
There was a problem hiding this comment.
it’s better to check by itemids variable. It’s more common
There was a problem hiding this comment.
Can u please clarify wym? Every isBulkRequest in code is const isBulkRequest = Array.isArray(originalInput)
pahaz
reviewed
Feb 3, 2025
| locale: { | ||
| schemaDoc: 'Locale of this field, For example, if you create SSN field (social security number) you should use en-US locale. If not set, then it is considered that this CustomField is global and not region specific', | ||
| type: 'Text', | ||
| isRequired: false, |
pahaz
reviewed
Feb 3, 2025
| validateInput: ({ resolvedData, fieldPath, addFieldValidationError }) => { | ||
| const value = resolvedData[fieldPath] | ||
| if (!(-100 < value && value <= 100)) { | ||
| return addFieldValidationError('priority should be between -100 and 100') |
pahaz
reviewed
Feb 3, 2025
| const schemaIsValid = ajv.validateSchema(value) | ||
|
|
||
| if (!schemaIsValid) { | ||
| addFieldValidationError('Bad validation rules, should be valid json-schema') |
pahaz
reviewed
Feb 3, 2025
| //template: 'miniapp.customField.*.name', | ||
| }, | ||
|
|
||
| priority: { |
There was a problem hiding this comment.
Yes, priority can be updated anytime. This changes only order in which fields are displayed in UI
pahaz
reviewed
Feb 3, 2025
| }, | ||
| }, | ||
|
|
||
| staffCanRead: { |
There was a problem hiding this comment.
It’s cool to add some todos for the staffCanEdit and solid fields.
pahaz
reviewed
Feb 3, 2025
| isRequired: true, | ||
| }, | ||
|
|
||
| filterDataString: { |
There was a problem hiding this comment.
Datetime is string, I think I'll just create a special type for that
pahaz
reviewed
Feb 3, 2025
pahaz
reviewed
Feb 3, 2025
| isRequired: false, | ||
| }, | ||
|
|
||
| isUniquePerObject: { |
pahaz
reviewed
Feb 3, 2025
| import { generateReactHooks } from '@open-condo/codegen/generate.hooks' | ||
| import { CustomValue as CustomValueGQL } from '@condo/domains/miniapp/gql' | ||
|
|
||
| // TODO(codegen): write utils like convertToFormState and formValuesProcessor if needed, otherwise delete this TODO |
toplenboren
force-pushed
the
toplenboren-customfields
branch
from
68763dc to
fcbe509
Compare
toplenboren
force-pushed
the
toplenboren-customfields
branch
from
fcbe509 to
8284b79
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for engineers to add their custom data to the condo