-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Create ADR for conflicting contributions
See #13 for previous related discussions Signed-off-by: Daniel Bartholomae <[email protected]>
- Loading branch information
1 parent
aff9dbe
commit 71dbea2
Showing
1 changed file
with
30 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# ADR-04-Conflicting-contributions | ||
|
||
| Status | | decided | | ||
| --- | --- | --- | | ||
| Date | | 2024-05-02 | | ||
| Decider | | @maintainers | | ||
|
||
## Context | ||
|
||
Sometimes, new functionality for this library is suggested that is already covered by other open source projects. Multiple of those projects might try to get incorporated into this one. | ||
|
||
## Options | ||
|
||
### Forgo adding existing solutions | ||
|
||
We could forgo adding existing solutions to our codebase. This would get around any kind of related conflict and the solutions would still be available. | ||
|
||
On the other hand, one of the goals of this library is to provide thoroughly testede solutions to make it easier for enterprise users to consume just one approved library. | ||
|
||
## Combine learnings from multiple solutions | ||
|
||
We could research alternatives and try to combine what we learn from those that are willing to contribute to create an improved solution. | ||
|
||
### Decide for a competing solutino | ||
|
||
We could also decide on one of the competing solutions where the maintainer is interested in contributing it to this library. This would be less work than combining multiple solutions, but it could lead to sub-par results. | ||
|
||
## Decision | ||
|
||
We research alternative solutions before accepting a contribution and reach out to their maintainers, so that we can discuss together the advantages and disadvantages of different solutions. We aim not to pit maintainers against each other, but instead to push for collaboration to combine the learnings from all solutions. |