-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-ec2): construct for EC2 Instance Connect Endpoint #22
feat(aws-ec2): construct for EC2 Instance Connect Endpoint #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Some small comments from my side
Please also run a full build to regenerate the API.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this PR. I would like to leave the rest to @hoegertn .
@go-to-k I've updated README.md after your approving. Could you please approve this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This PR introduces the Construct for the EC2 Instance Connect Endpoint, allowing users to easily generate an endpoint and connect to an EC2 instance.
Users only need to specify the
vpc
property and can configure additional properties as needed.This PR includes both unit and integ tests.