Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-ec2): construct for EC2 Instance Connect Endpoint #22

Merged
merged 19 commits into from
May 4, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Apr 29, 2024

This PR introduces the Construct for the EC2 Instance Connect Endpoint, allowing users to easily generate an endpoint and connect to an EC2 instance.

Users only need to specify the vpc property and can configure additional properties as needed.

    const instanceConnectEndpoint = new aws_ec2.InstanceConnectEndpoint(
      this,
      'InstanceConnectEndpoint',
      {
        vpc,
        clientToken: 'my-client-token', // optional
        securityGroups: [securityGroup], // optional
        preserveClientIp: true, // optional
      },
    );

    instanceConnectEndpoint.connections.allowTo(instance, cdk.aws_ec2.Port.tcp(22));

This PR includes both unit and integ tests.

Copy link
Contributor

@hoegertn hoegertn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Some small comments from my side

src/aws-ec2/instance-connect-endpoint.ts Outdated Show resolved Hide resolved
src/aws-ec2/instance-connect-endpoint.ts Outdated Show resolved Hide resolved
src/aws-ec2/instance-connect-endpoint.ts Show resolved Hide resolved
@hoegertn
Copy link
Contributor

hoegertn commented May 1, 2024

Please also run a full build to regenerate the API.md file

src/aws-ec2/instance-connect-endpoint.ts Outdated Show resolved Hide resolved
src/aws-ec2/instance-connect-endpoint.ts Outdated Show resolved Hide resolved
go-to-k
go-to-k previously approved these changes May 2, 2024
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this PR. I would like to leave the rest to @hoegertn .

src/aws-ec2/README.md Outdated Show resolved Hide resolved
@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented May 4, 2024

@go-to-k I've updated README.md after your approving. Could you please approve this again?

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@hoegertn hoegertn added this pull request to the merge queue May 4, 2024
Merged via the queue into open-constructs:main with commit f1fafb2 May 4, 2024
5 checks passed
@badmintoncryer badmintoncryer deleted the instanceConnectEndpoint branch May 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants