Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automate upgrade AWS CDK #34

Closed
wants to merge 3 commits into from
Closed

Conversation

WinterYukky
Copy link
Contributor

Reason for this change

The AWS CDK version for this repository has not been updated. However, since it is inefficient for contributors to update this every time, we need automate process.

Description of changes

I implemented GitHub Actions that create a pull request to upgrade the AWS CDK version at 0 UTC every day.

Description of how you validated changes

I tested on WinterYukky/projen-auto-upgrade-cdk#2.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@WinterYukky WinterYukky added the enhancement New feature or request label May 27, 2024
.projenrc.ts Outdated Show resolved Hide resolved
@mrgrain
Copy link
Contributor

mrgrain commented May 27, 2024

I don't think this is a good idea. It unnecessarily forces users to update to the latest version of aws-cdk-lib when they just want to upgrade @open-constructs/aws-cdk.

But then I also think that changing a peerDeps constraint should require a major version change. 😅

As a possible solution I can only suggest what I have suggested before: A well-define regular cycle for the release of new major versions which will include lifting the minimal version requirement to whatever is latest at that time.

@go-to-k
Copy link
Contributor

go-to-k commented May 27, 2024

Oh, we have talked about that before. FYI, I post that link for discussion @WinterYukky .

#12

@WinterYukky
Copy link
Contributor Author

Ah, I see. That's right.
First, We should documentation about major version release schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants