feat(aws-redshiftserverless): support Namespace and Workgroup L2 construct #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazyu36
commented
Sep 11, 2024
mazyu36
force-pushed
the
redshift-serverless
branch
from
9e7dea4 to
35629f6
Compare
mazyu36
changed the title
mazyu36
force-pushed
the
redshift-serverless
branch
from
7aa155f to
3b71877
Compare
mazyu36
commented
Sep 14, 2024
go-to-k
changed the title
hoegertn
reviewed
Sep 25, 2024
hoegertn
reviewed
Sep 25, 2024
hoegertn
reviewed
Sep 25, 2024
hoegertn
reviewed
Sep 25, 2024
go-to-k
requested changes
Sep 28, 2024
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
go-to-k
requested changes
Sep 29, 2024
go-to-k
reviewed
Sep 29, 2024
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
go-to-k
requested changes
Sep 30, 2024
go-to-k
requested changes
Sep 30, 2024
go-to-k
requested changes
Sep 30, 2024
go-to-k
reviewed
Sep 30, 2024
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: mazyu36 <[email protected]>
|
@go-to-k |
go-to-k
approved these changes
Oct 1, 2024
|
CI with build also passed. Can we merge this PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #44 .
Reason for this change
To support Redshift Serverless Namespace and Workgroup L2 Construct.
Description of changes
Add
NamespaceandWorkgroupclass.In general, I am implementing properties based on those supported by
aws-cdk-libv2.120.0.backlog: #45
Description of how you validated changes
Add unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license