Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add rule for PR title about module scope #49

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 14, 2024

Issue # (if applicable)

Closes #.

Reason for this change

In the case of changes to a specific module, the scope of the title should include the name of that module. Also, the aws- part should not be omitted.

e.g.) feat(aws-s3): description of the change

See: #24 (comment) (Originally omitted aws- and scoped as cur.)

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

.projenrc.ts Show resolved Hide resolved
@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 14, 2024

Waiting for the PR to be merged.

@hoegertn hoegertn added this pull request to the merge queue Sep 15, 2024
Merged via the queue into open-constructs:main with commit 649175a Sep 15, 2024
6 checks passed
@go-to-k go-to-k deleted the contribution-guide-pr-title branch September 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants