-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codeartifact): add L2 constructs for Repository & Domain #54
Conversation
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Benjamin Genz <[email protected]>
Co-authored-by: Roman <[email protected]> Signed-off-by: Benjamin Genz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for commenting so much when it's still in draft form. However, I think we are getting a very good Constructs.
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Benjamin Genz <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Benjamin Genz <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Benjamin Genz <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Benjamin Genz <[email protected]>
@go-to-k I cannot run the integration tests and therefore update the snapshots in the required regions (us-east-1, us-east-2, us-west-2), due to compliance reasons. I could only do eu-central-1 (i.e. that's why this was set). Please, could you run the integration tests for me? |
I see, okay. Once the KMS is finished talking about it and the fixes are all in place, I (or we) will run it. P.S. see: #54 (comment) |
Can you run the test with an option npx projen test/aws-codeartifact/integ.codeartifact.ts --parallel-regions eu-central-1 --update-on-failed |
@bweigel please also merge the main branch so we can do a test build |
@go-to-k is there anything open from your side? I would love to see that in the library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue # (if applicable)
Closes #52
Reason for this change
There is no L2 construct for Repository or Domain.
Description of changes
Domain
classRepository
classDescription of how you validated changes
Added unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license