Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codeartifact): add L2 constructs for Repository & Domain #54

Merged
merged 49 commits into from
Oct 11, 2024

Conversation

bweigel
Copy link
Contributor

@bweigel bweigel commented Sep 18, 2024

Issue # (if applicable)

Closes #52

Reason for this change

There is no L2 construct for Repository or Domain.

Description of changes

  • add Domain class
  • add Repository class

Description of how you validated changes

Added unit and integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@bweigel bweigel changed the title (codeartifact): add L2 constructs for Repository & Domain feat(codeartifact): add L2 constructs for Repository & Domain Sep 18, 2024
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/README.md Outdated Show resolved Hide resolved
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/README.md Outdated Show resolved Hide resolved
src/aws-codeartifact/README.md Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for commenting so much when it's still in draft form. However, I think we are getting a very good Constructs.

src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Benjamin Genz <[email protected]>
@bweigel
Copy link
Contributor Author

bweigel commented Sep 26, 2024

@go-to-k I cannot run the integration tests and therefore update the snapshots in the required regions (us-east-1, us-east-2, us-west-2), due to compliance reasons. I could only do eu-central-1 (i.e. that's why this was set).

Please, could you run the integration tests for me?

src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/repository.ts Outdated Show resolved Hide resolved
src/aws-codeartifact/domain.ts Outdated Show resolved Hide resolved
@go-to-k
Copy link
Contributor

go-to-k commented Sep 26, 2024

@bweigel

@go-to-k I cannot run the integration tests and therefore update the snapshots in the required regions (us-east-1, us-east-2, us-west-2), due to compliance reasons. I could only do eu-central-1 (i.e. that's why this was set).

Please, could you run the integration tests for me?

I see, okay. Once the KMS is finished talking about it and the fixes are all in place, I (or we) will run it.

P.S.

see: #54 (comment)

@go-to-k
Copy link
Contributor

go-to-k commented Sep 29, 2024

@bweigel

@go-to-k I cannot run the integration tests and therefore update the snapshots in the required regions (us-east-1, us-east-2, us-west-2), due to compliance reasons. I could only do eu-central-1 (i.e. that's why this was set).

Please, could you run the integration tests for me?

Can you run the test with an option --parallel-regions for the integ command? This would be good because there would be no region information left in the code.

npx projen test/aws-codeartifact/integ.codeartifact.ts --parallel-regions eu-central-1 --update-on-failed

@hoegertn
Copy link
Contributor

hoegertn commented Oct 6, 2024

@bweigel please also merge the main branch so we can do a test build

@hoegertn
Copy link
Contributor

hoegertn commented Oct 9, 2024

@go-to-k is there anything open from your side? I would love to see that in the library.

@go-to-k
Copy link
Contributor

go-to-k commented Oct 9, 2024

@hoegertn @bweigel

Sorry. Haven't had a chance to look at the changes yet, but will do so this week and comment.

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bweigel @hoegertn

Thank you for your patience. I have checked all the changes and there are no problems. It has been a great Construct.

I will merge.

@go-to-k go-to-k added this pull request to the merge queue Oct 11, 2024
Merged via the queue into open-constructs:main with commit f19707e Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(codeartifact) Add support for L2 constructs Domain & Repository
4 participants