Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stage object descriptions, release tags and planning process description #1415

Merged

Conversation

JachymHercher
Copy link
Contributor

Closes #1385

Closes #866

@JachymHercher JachymHercher added Codelist: Closed Relating to a closed codelist Codelist: Open Relating to an open codelist Semantics Relating to field and code descriptions labels Sep 19, 2021
@jpmckinney jpmckinney force-pushed the 1385-update-all-stage-object-descriptions-and-release-tags branch from 87d9a34 to ed37c4e Compare September 24, 2021 05:04
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion. @yolile, feel free to merge if the suggestion is applied.

schema/release-schema.json Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

Regarding:

Planning processes must not use the 'tender' code, even if they use tender fields.

I think the use of "must" here is okay (typically, new "must" statements are not possible in a minor release), because a planning process is identified by the release tag or the tender.status (both of which are expected to align), such that the use of the 'tender' code would imply that the planning process is actually a contracting process – meaning that this new rule can't really be broken. That said, it's still useful to express as a rule, to avoid the blurring of the types of processes.

@JachymHercher
Copy link
Contributor Author

Just one suggestion. @yolile, feel free to merge if the suggestion is applied.

Just to be sure - did you really mean @yolile or me? :)

@jpmckinney
Copy link
Member

I meant @yolile, so that a reviewer merges, rather than the author :) But I can merge now.

@jpmckinney jpmckinney merged commit 4684e13 into 1.2-dev Oct 12, 2021
@jpmckinney jpmckinney deleted the 1385-update-all-stage-object-descriptions-and-release-tags branch October 12, 2021 14:49
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codelist: Closed Relating to a closed codelist Codelist: Open Relating to an open codelist Semantics Relating to field and code descriptions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update all stage object descriptions and release tags Clarify definition of contracting process
2 participants